> Subject: Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows > errors to errno-style errors > > External email: Use caution opening links or attachments > > > > Also, I don't think this is a thread specific function, other > > implementations > can use it in the future, maybe move it to rte_windows.h? > > I'd suggest that it's probably better suited to a .c file rather than a > header. As > an example of what it might end up like see > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fwpdk%2Fwpdk%2Fblob%2Fmaster%2Fsrc%2Ferror.c&data= > 04%7C01%7Ctalshn%40nvidia.com%7C4ab2e17b824842b9f83208d8f48ab4ec > %7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637528223860057761 > %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=AnBHMtSobODNzb > Uhun3GVnsTiePl%2BQzfPSASlur81Ks%3D&reserved=0 > > Regards, > Nick >
Agreed, thanks Nick.
