Re: [dpdk-dev] [PATCH v3 3/5] kvargs: add get by key function

[Kinsella, Ray]

On 30/03/2021 13:15, Xueming Li wrote:
> Adds a new function to get value of a specific key from kvargs list.
> 
> Signed-off-by: Xueming Li <xuemi...@nvidia.com>
> ---
>  lib/librte_kvargs/rte_kvargs.c | 20 ++++++++++++++++++++
>  lib/librte_kvargs/rte_kvargs.h | 21 +++++++++++++++++++++
>  lib/librte_kvargs/version.map  |  1 +
>  3 files changed, 42 insertions(+)
> 

[SNIP]

> diff --git a/lib/librte_kvargs/version.map b/lib/librte_kvargs/version.map
> index ed375bf4a3..e2bf792c60 100644
> --- a/lib/librte_kvargs/version.map
> +++ b/lib/librte_kvargs/version.map
> @@ -12,6 +12,7 @@ DPDK_21 {
>  EXPERIMENTAL {
>       global:
>
Please separate rte_kvargs_get from the other symbols.
And add #21.05 in front, so we know when the symbol got added. 

> +     rte_kvargs_get;
>       rte_kvargs_parse_delim;
>       rte_kvargs_strcmp;
>  
>