On 3/24/2021 6:05 PM, Ferruh Yigit wrote:
On 3/21/2021 9:00 AM, Thomas Monjalon wrote:
Since rte_flow is the only API for filtering operations,
the legacy driver interface filter_ctrl was too much complicated
for the simple task of getting the struct rte_flow_ops.

The filter type RTE_ETH_FILTER_GENERIC and
the filter operarion RTE_ETH_FILTER_GET are removed.
The new driver callback flow_ops_get replaces filter_ctrl.

Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
Acked-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
Acked-by: Haiyue Wang <haiyue.w...@intel.com>
Acked-by: Rosen Xu <rosen...@intel.com>
Acked-by: Hemant Agrawal <hemant.agra...@nxp.com>

Except from following minor issue,

Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>

--- a/drivers/net/dpaa2/dpaa2_flow.c
+++ b/drivers/net/dpaa2/dpaa2_flow.c
@@ -89,8 +89,6 @@ enum rte_flow_action_type dpaa2_supported_action_type[] = {
  /* Max of enum rte_flow_item_type + 1, for both IPv4 and IPv6*/
  #define DPAA2_FLOW_ITEM_TYPE_GENERIC_IP (RTE_FLOW_ITEM_TYPE_META + 1)
-enum rte_filter_type dpaa2_filter_type = RTE_ETH_FILTER_NONE;
-

Need to remove the 'dpaa2_filter_type' extern from 'dpaa2_ethdev.h' too.

Applied to dpdk-next-net/main, thanks.

(extern from 'dpaa2_ethdev.h' removed while merging)

Only 1/2 merged, 2/2 can be discussed more or merged later.

Reply via email to