> -----Original Message-----
> From: Jerin Jacob Kollanukkaran <jer...@marvell.com>
> Sent: Sunday, March 21, 2021 5:30 AM
> To: McDaniel, Timothy <timothy.mcdan...@intel.com>; dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haa...@intel.com>; m...@ashroe.eu;
> nhor...@tuxdriver.com; Rao, Nikhil <nikhil....@intel.com>; Carrillo, Erik G
> <erik.g.carri...@intel.com>; Gujjar, Abhinandan S
> <abhinandan.guj...@intel.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavat...@marvell.com>; hemant.agra...@nxp.com; mattias.ronnblom
> <mattias.ronnb...@ericsson.com>; Mccarthy, Peter
> <peter.mccar...@intel.com>
> Subject: RE: [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware
> init
>
> > -----Original Message-----
> > From: Timothy McDaniel <timothy.mcdan...@intel.com>
> > Sent: Wednesday, March 17, 2021 3:49 AM
> > To: dev@dpdk.org
> > Cc: Jerin Jacob Kollanukkaran <jer...@marvell.com>;
> > harry.van.haa...@intel.com; m...@ashroe.eu; nhor...@tuxdriver.com;
> > nikhil....@intel.com; erik.g.carri...@intel.com;
> > abhinandan.guj...@intel.com;
> > Pavan Nikhilesh Bhagavatula <pbhagavat...@marvell.com>;
> > hemant.agra...@nxp.com; mattias.ronnb...@ericsson.com;
> > peter.mccar...@intel.com
> > Subject: [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware
> > init
>
>
> Please simplify subject in all the patches like
> event/dlb2: add v2.5 HW init
>
Will do
>
> > ----------------------------------------------------------------------
> > This commit adds support for DLB v2.5 probe-time hardware init,
> > and sets up a framework for incorporating the remaining
> > changes required to support DLB v2.5.
> >
> > DLB v2.0 and DLB v2.5 are similar in many respects, but their
> > register offsets and definitions are different. As a result of these,
> > differences, the low level hardware functions must take the devicei
>
>
> s/devicei/device
>
fixed
> > version into consideration. This requires that the hardware version be
> > passed to many of the low level functions, so that the PMD can
> > take the appropriate action based on the device version.
> >
> > To ease the transition and keep the individual patches small, three
> > temporary files are added in this commit. These files have "new"
> > in their names. The files with "new" contain changes specific to a
> > consolidated PMD that supports both DLB v2.0 and DLB 2.5. Their sister
> > files of the same name (minus "new") contain the old DLB v2.0 specific
> > code. The intent is to remove code from the original files as that code
> > is ported to the combined DLB 2.0/2.5 PMD model and added to the "new"
> > files in a series of commits. At end of the patch series, the old files
> > will be empty and the "new" files will have the logic needed
> > to implement a single PMD that supports both DLB v2.0 and DLB v2.5.
> > At that time, the original DLB v2.0 specific files will be deleted,
> > and the "new" files will be renamed and replace them.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdan...@intel.com>
> > ---
> > drivers/event/dlb2/dlb2_priv.h | 5 +
> > drivers/event/dlb2/meson.build | 1 +
> > .../event/dlb2/pf/base/dlb2_hw_types_new.h | 362 ++
> > drivers/event/dlb2/pf/base/dlb2_mbox.h | 1 -
> > drivers/event/dlb2/pf/base/dlb2_osdep.h | 4 +
> > drivers/event/dlb2/pf/base/dlb2_regs_new.h | 4412 +++++++++++++++++
> > drivers/event/dlb2/pf/base/dlb2_resource.c | 180 +-
> > drivers/event/dlb2/pf/base/dlb2_resource.h | 36 -
> > .../event/dlb2/pf/base/dlb2_resource_new.c | 271 +
> > .../event/dlb2/pf/base/dlb2_resource_new.h | 73 +
> > drivers/event/dlb2/pf/dlb2_main.c | 41 +-
> > drivers/event/dlb2/pf/dlb2_main.h | 4 +
> > drivers/event/dlb2/pf/dlb2_pf.c | 6 +-
> > 13 files changed, 5165 insertions(+), 231 deletions(-)
> > create mode 100644 drivers/event/dlb2/pf/base/dlb2_hw_types_new.h
> > create mode 100644 drivers/event/dlb2/pf/base/dlb2_regs_new.h
> > create mode 100644 drivers/event/dlb2/pf/base/dlb2_resource_new.c
> > create mode 100644 drivers/event/dlb2/pf/base/dlb2_resource_new.h
> >
> > +#ifdef FPGA
>
> Don't do this. Either detect the FPGA presence or make it devargs
>
> > +#define DLB2_HZ 2000000
> > +#else
> > +#define DLB2_HZ 800000000
> > +#endif
> > +
> > +
> > +/* TEMPORARY inclusion of both headers for merge */
>
fixed
>
> Please make sure to remove this comments in sub sequent patches.
>
will do
> > b/drivers/event/dlb2/pf/dlb2_main.h
> > index f3bee71fb..01a24e8a4 100644
> > --- a/drivers/event/dlb2/pf/dlb2_main.h
> > +++ b/drivers/event/dlb2/pf/dlb2_main.h
> > @@ -15,7 +15,11 @@
> > #define PAGE_SIZE (sysconf(_SC_PAGESIZE))
>
> Please use DPDK APIs for this.
>
done
> > #endif
