> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Wednesday, March 24, 2021 1:16 PM > To: Kathleen Capella <kathleen.cape...@arm.com> > Cc: dev@dpdk.org; nd <n...@arm.com>; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com> > Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge > case > > 23/02/2021 19:23, Kathleen Capella: > > Initialize prev_tsc to cur_tsc. This avoids running the TX queue drain > > in the first iteration of the packet processing loop. > > Is it really a fix? What was broken? > Isn't it an optimization?
It could be considered an optimization since effectively it prevents entering the if statement on the first iteration of the loop. I will remove the "fixes" line and reword the subject line. > > > Fixes: af75078fece3 ("first public release") > > If it's really a fix, we should probably backport it, so > Cc: sta...@dpdk.org [Kathleen Capella] It is not really a significant problem to be fixed in previous releases so it does not need to be backported. > > > Signed-off-by: Kathleen Capella <kathleen.cape...@arm.com> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > >