25/03/2021 18:10, Ferruh Yigit: > On 3/9/2021 1:18 PM, Jiawei Wang wrote: > > Update documentation for sample action usage in testpmd and > > show the command line example. > > > > +1 to document this. > > Indeed for all testpmd flow update, it must be mandatory to update "Flow > rules > management" section for it, Ori what do you think? > > > Signed-off-by: Jiawei Wang <jiaw...@nvidia.com> > > Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> > > <...> > > > +Sample Sampling/Mirroring rules > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +Sample/Mirroring rules can be set by the following commands > > + > > +NIC-RX Sampling rule, the matched ingress packets are duplicated and sent > > to > > +the queue 1, and each second packets are marked with 0x1234 and sent to > > +queue 0. > > + > > Also each second packets duplicated to queue 1, isn't it, because of 'ratio > 2'? > > > +:: > > + > > + testpmd> set sample_actions 0 mark id 0x1234 / queue index 0 / end > > + testpmd> flow create 0 ingress group 1 pattern eth / end actions > > + sample ratio 2 index 0 / queue index 1 / end > > + > > +E-Switch Sampling rule, the matched ingress packets are duplicated and sent > > +to port id 2, and each second packets are sent to eswitch manager. > > + > > what is 'E-Switch', or "eswitch manager", isn't the mirror rule generic?
This is the HW switch in Mellanox devices. It should not be mentioned in this generic doc.