On 3/24/2021 10:59 AM, Ferruh Yigit wrote:
On 3/16/2021 10:51 AM, Jiawen Wu wrote:
Add device arguments to support runtime options. These arguments are
only set for backplane NICs.
Signed-off-by: Jiawen Wu <jiawe...@trustnetic.com>
<...>

+
+#define TXGBE_DEVARG_BP_AUTO        "auto"
+#define TXGBE_DEVARG_KR_POLL        "poll"
+#define TXGBE_DEVARG_KR_PRESENT        "present"
+#define TXGBE_DEVARG_KX_SGMII        "sgmii"
+#define TXGBE_DEVARG_FFE_SET        "ffe_set"
+#define TXGBE_DEVARG_FFE_MAIN        "ffe_main"
+#define TXGBE_DEVARG_FFE_PRE        "ffe_pre"
+#define TXGBE_DEVARG_FFE_POST        "ffe_post"
+
I just recognized that this patch is adding devargs without using them, and 
later patches are using them. This separates them from the full context.
Can you please add them gradually as they are used, in the same patch they are 
used?
Meanwhile you can add the release notes update in next version.

Thanks,
ferruh
And I think 'auto' can be 'auto_neg', since 'auto' is too generic, but up to 
you.

Reply via email to