> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Wednesday, March 24, 2021 9:05 AM
> To: Khangar, Churchill <churchill.khan...@intel.com>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitre...@intel.com>; P,
> Venkata Suresh Kumar <venkata.suresh.kuma...@intel.com>; Jangra,
> Yogesh <yogesh.jan...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] examples/pipeline: fix strtoul base
> 
> 05/03/2021 16:15, Churchill Khangar:
> > This patch addresses the issue with strtoul base
> 
> Which issue?
> Please explain what is broken and how it is fixed.
> 
> 

Nothing is broken here, this is incorrectly labeled as a fix. This is simply an 
small improvement to allow specification of integer arguments for the CLI 
commands in hexadecimal ( and octal :) ) as well as decimal, as opposed to just 
decimal.

Churchill, it would be great if you could update the title and description to 
reflect this as opposed to claiming a fix, and send v2, thanks!

Regards,
Cristian 

Reply via email to