> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Monday, March 22, 2021 06:31
> To: dev@dpdk.org
> Cc: david.march...@redhat.com; sta...@dpdk.org; Ajit Khaparde
> <ajit.khapa...@broadcom.com>; Richardson, Bruce
> <bruce.richard...@intel.com>; Andrew Rybchenko
> <andrew.rybche...@oktetlabs.ru>; Li, Xiaoyun <xiaoyun...@intel.com>; Ori
> Kam <or...@nvidia.com>; Bing Zhao <bi...@nvidia.com>; Iremonger, Bernard
> <bernard.iremon...@intel.com>; Jens Freimann <jfreim...@redhat.com>;
> Kevin Traynor <ktray...@redhat.com>; Stephen Hemminger
> <step...@networkplumber.org>; Maciej Czekaj
> <maciej.cze...@caviumnetworks.com>; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>
> Subject: [PATCH v4 11/11] app/testpmd: fix usage text
> 
> The options help text was including an incomplete and redundant summary of
> the options before explaining each. The summary is dropped.
> 
> The details of the option --hairpin-mode had an extra space, breaking the
> alignment with the next line.
> 
> There were some mismatches between options in the usage text
>       sed -rn 's/.*\(" *--([a-z-]*)[=: ].*/\1/p' app/test-pmd/parameters.c and
> the options declared in lgopts array
>       sed -rn 's/.*\{.*"(.*)",.*,.*,.*},.*/\1/p' app/test-pmd/parameters.c The
> misses were:
>       --no-numa
>       --enable-scatter
>       --tx-ip
>       --tx-udp
>       --noisy-lkup-num-reads-writes
> The option --ports was not implemented.
> 
> Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup")
> Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode")
> Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP 
> parameters")
> Fixes: 0499793854f5 ("app/testpmd: add scatter enabling option")
> Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default")
> Fixes: af75078fece3 ("first public release")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> Acked-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
> Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
> ---

Acked-by: Xiaoyun Li <xiaoyun...@intel.com>

Reply via email to