> -----Original Message----- > From: Xiaozhen Ban <benhaz1...@gmail.com> > Sent: Wednesday, March 17, 2021 17:16 > To: Guo, Jia <jia....@intel.com>; Wang, Haiyue <haiyue.w...@intel.com> > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/e1000: fix filter control return value > > If filter_type not supported, eth_igb_filter_ctrl() will return > incorrect value. > > Fixes: dd5c2dd7e5e5 ("igb: use generic filter control for ethertype filter") > Cc: sta...@dpdk.org > Signed-off-by: Xiaozhen Ban <benhaz1...@gmail.com> > --- > drivers/net/e1000/igb_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c > index 1716d6b90..325461247 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -4599,6 +4599,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev > __rte_unused, > default: > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported", > filter_type); > + ret = -EINVAL; > break; > } >
New design will be applied: https://patchwork.dpdk.org/project/dpdk/patch/20210312174645.162801-2-tho...@monjalon.net/ > -- > 2.25.1