I have comments for that. Pls see below. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 29, 2015 8:57 PM > To: Ouyang, Changchun > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering > > Back on this old patch, it seems justified but nobody agreed. > > --- a/lib/librte_pmd_virtio/virtio_ethdev.c > +++ b/lib/librte_pmd_virtio/virtio_ethdev.c > @@ -1288,7 +1288,6 @@ virtio_dev_configure(struct rte_eth_dev *dev) > && !vtpci_with_feature(hw, VIRTIO_NET_F_CTRL_VLAN)) { > PMD_DRV_LOG(NOTICE, > "vlan filtering not available on this host"); > - return -ENOTSUP; > } > > 2015-03-06 08:24, Stephen Hemminger: > > "Ouyang, Changchun" <changchun.ouyang at intel.com> wrote: > > > > From: Stephen Hemminger > > > > Vlan filtering is an option, and not a requirement. > > > > If host does not support filtering then it can be done in software.
Yes, vlan filter is an option, but currently virtio driver has no software solution for vlan filter. So I would like to disable hw_vlan_filter in rxmode if the dev can't really support it rather than removing the return there. > > > > > > The question is that guest only send command, no real action to do the > vlan filter. > > > So if both host and guest have no real action for vlan filter, who will > > > do it? > > > > The virtio driver has features. > > Guest can not send commands to host where feature bit not enabled. > > Application can call filter_set and check if filter worked or not. > > > > Our code already had to do MAC and VLAN validation of incoming packets There is vlan strip, but have no vlan filter in the rx function. > > therefore if hardware can't do vlan match, there is no problem. > > I would expect other applications would do the same thing. > > > > Failing during configuration is bad. DPDK API should never force > > application to play "guess the working configuration" with the device > > driver or do string match on "which device is this anyway"
