On Wed, 10 Mar 2021 12:10:01 +0100
Thomas Monjalon <tho...@monjalon.net> wrote:
> 10/03/2021 12:04, Dharmik Thakkar:
> > Enable volatile considered harmful warning since use of volatile
> > is suspect.
> >
> > Suggested-by: Stephen Hemminger <step...@networkplumber.org>
> > Signed-off-by: Dharmik Thakkar <dharmik.thak...@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com>
>
> git grep -w volatile | wc -l
> 1796
>
> How much is it suspect?
>
>
Many seem to be unsafe.
testpmd: uses flags values in unsafe manner
it also uses volatile when accessing hardware registers
test-alarm is expecting that alarm() is a signal
(it is not)
test-atomic is ok
test-barrier is doing barriers and not using __atomic
drivers use volatile to mark hardware registers.
It is still true volatile is not enough are not weak memory model.
