Hi
> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Lijun Ou
> Sent: Friday, March 5, 2021 08:56
> To: Yigit, Ferruh <ferruh.yi...@intel.com>
> Cc: dev@dpdk.org; linux...@openeuler.org
> Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: fix mixed use of RX/Rx/TX/Tx in
> testpmd
>
> From: Hongbo Zheng <zhenghong...@huawei.com>
>
> In testpmd, when we input "show config rxtx", we can see like this:
>
> 1: testpmd> show config rxtx
> 2: io packet forwarding packets/burst=32
> 3: nb forwarding cores=1 - nb forwarding ports=1
> 4: port 0: RX queue number: 1 Tx queue number: 1
> 5: Rx offloads=0x0 Tx offloads=0x10000
> 6: RX queue: 0
> 7: RX desc=1024 - RX free threshold=32
> 8: RX threshold registers: pthresh=0 hthresh=0 wthresh=0
> 9: RX Offloads=0x0
> 10: TX queue: 0
> 11: TX desc=1024 - TX free threshold=928
> 12: TX threshold registers: pthresh=0 hthresh=0 wthresh=0
> 13: TX offloads=0x10000 - TX RS bit threshold=32
>
> In line 4, RX/Tx is mixed used. Also in other lines, RX/Rx/TX/Tx is mixed
> used.
If you're going to unify the print to only use "Rx/Tx" in testpmd as your title
said.
There're a lot of more places using RX/TX when printing. You should change them
too.
>
> This patch fix the mixed use of RX/Rx/TX/Tx in testpmd command "show config
> rxtx" output by change to unified use Rx/Tx.
>
> Signed-off-by: Hongbo Zheng <zhenghong...@huawei.com>
> Signed-off-by: Lijun Ou <ouli...@huawei.com>
> ---
> app/test-pmd/config.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 576d5ac..2435c26 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2505,7 +2505,7 @@ rxtx_config_display(void)
> int32_t rc;
>
> /* per port config */
> - printf(" port %d: RX queue number: %d Tx queue
> number: %d\n",
> + printf(" port %d: Rx queue number: %d Tx queue number: %d\n",
> (unsigned int)pid, nb_rxq, nb_txq);
>
> printf(" Rx offloads=0x%"PRIx64" Tx offloads=0x%"PRIx64"\n",
> @@ -2533,13 +2533,13 @@ rxtx_config_display(void)
> offloads_tmp = rx_qinfo.conf.offloads;
> }
>
> - printf(" RX queue: %d\n", qid);
> - printf(" RX desc=%d - RX free threshold=%d\n",
> + printf(" Rx queue: %d\n", qid);
> + printf(" Rx desc=%d - Rx free threshold=%d\n",
> nb_rx_desc_tmp, rx_free_thresh_tmp);
> - printf(" RX threshold registers: pthresh=%d
> hthresh=%d "
> + printf(" Rx threshold registers: pthresh=%d
> hthresh=%d "
> " wthresh=%d\n",
> pthresh_tmp, hthresh_tmp, wthresh_tmp);
> - printf(" RX Offloads=0x%"PRIx64"\n", offloads_tmp);
> + printf(" Rx Offloads=0x%"PRIx64"\n", offloads_tmp);
> }
>
> /* per tx queue config only for first queue to be less verbose
> */
> @@ -2565,13 +2565,13 @@ rxtx_config_display(void)
> tx_rs_thresh_tmp = tx_qinfo.conf.tx_rs_thresh;
> }
>
> - printf(" TX queue: %d\n", qid);
> - printf(" TX desc=%d - TX free threshold=%d\n",
> + printf(" Tx queue: %d\n", qid);
> + printf(" Tx desc=%d - Tx free threshold=%d\n",
> nb_tx_desc_tmp, tx_free_thresh_tmp);
> - printf(" TX threshold registers: pthresh=%d
> hthresh=%d "
> + printf(" Tx threshold registers: pthresh=%d
> hthresh=%d "
> " wthresh=%d\n",
> pthresh_tmp, hthresh_tmp, wthresh_tmp);
> - printf(" TX offloads=0x%"PRIx64" - TX RS bit
> threshold=%d\n",
> + printf(" Tx offloads=0x%"PRIx64" - Tx RS bit
> threshold=%d\n",
> offloads_tmp, tx_rs_thresh_tmp);
> }
> }
> --
> 2.7.4
