On 2/24/2021 11:18 AM, Ciara Loftus wrote:
Prior to this the max size was 32 which was unnecessarily
small.

Can you please describe the impact? Why changed from 32 to 512?
I assume this is to improve the performance but can you please explicitly document it in the commit log?

Also enforce the max batch size for TX for both
copy and zero copy modes. Prior to this only copy mode
enforced the max size.


By enforcing, the PMD ignores the user provided burst value if it is more than PMS supported MAX, and this ignoring is done in silent. Also there is no way to discover this MAX value without checking the code.

Overall, why this max values are required at all? After quick check I can see they are used for some bulk operations, which I assume can be eliminated, what do you think?

Signed-off-by: Ciara Loftus <ciara.lof...@intel.com>

<...>

Reply via email to