On 2/7/2021 1:58 AM, Li, Xiaoyun wrote:
-----Original Message-----
From: Yigit, Ferruh <ferruh.yi...@intel.com>
Sent: Friday, February 5, 2021 22:27
To: Lu, Wenzhuo <wenzhuo...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>;
Iremonger, Bernard <bernard.iremon...@intel.com>
Cc: Yigit, Ferruh <ferruh.yi...@intel.com>; dev@dpdk.org
Subject: [PATCH] app/testpmd: remove duplicated offload display
"show port cap all|<port_id>" was to display offload configuration of port(s).
But later two other commands added to show same information in more
accurate way:
show port (port_id) rx_offload configuration show port (port_id) tx_offload
configuration
These new commands can both show port and queue level configuration, also
with their capabilities counterparts easier to see offload capability and
configuration of the port in similar syntax.
So the functionality is duplicated and removing this version, to favor the new
commands.
Another problem with this command is it requires each new offload to be added
into the function to display them, and there were missing offloads that are not
displayed, this requirement for sure will create gaps by time as new offloads
added.
Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com>
Acked-by: Xiaoyun Li <xiaoyun...@intel.com>
Applied to dpdk-next-net/main, thanks.
