> Subject: Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX > symbols > > External email: Use caution opening links or attachments > > > On Sun, 21 Feb 2021 08:59:50 +0000, Tal Shnaiderman wrote: > [...] > > > -#ifndef close > > > -#define close _close > > > -#endif > > > > mlx5 uses close() in mlx5.c and is broken after this change above, BTW why > not add an rte_close instead of local definition? > > I'm reluctant to add file manipulation API to EAL. It would be replication of > POSIX with "rte_" prefix, while standard C has everything needed to deal > with files (and IOCTLs are platform-specific code anyway). I think libraries > and > PMDs striving to be cross-platform should move to using FILE* some day. For > now, local definitions keep them running without any risk of breakage. > > Thanks for all your comments, it's weird I didn't hit the failures locally. > Will fix in v3.
You might be missing the DevX SDK installation, without it meson will skip the mlx5 build. You can get it either by installation WIOF2 2.60 [1] or get only the SDK from [2] (I attached it to the Bugzilla ticket when asked the UNH team to add mlx5 compilation to CI. [1] - https://www.mellanox.com/products/adapter-software/ethernet/windows/winof-2 [2] - https://bugs.dpdk.org/show_bug.cgi?id=620
