On 03-Dec-20 8:25 AM, Liu, Yongxin wrote:
Hi Anatoly,
Do you have any further comments on this v5?
Or you can submit your own patch directly.
I am really expecting this issue to be fixed.
Thank you very much.
Yongxin
-----Original Message-----
From: dev <dev-boun...@dpdk.org> On Behalf Of Yongxin Liu
Sent: Monday, November 23, 2020 11:06
To: dev@dpdk.org; anatoly.bura...@intel.com; tho...@monjalon.net
Subject: [dpdk-dev] [PATCH v5] usertools/devbind: fix binding for built-in
kernel drivers
A driver can be loaded as a dynamic module or a built-in module.
In commit 681a67288655 ("usertools: check if module is loaded before
binding"), script only checks modules in /sys/module/.
However, for built-in kernel driver, it only shows up in /sys/module/, if
it has a version or at least one parameter. So add check for modules in
/lib/modules/$(uname -r)/modules.builtin.
Signed-off-by: Yongxin Liu <yongxin....@windriver.com>
---
v5:
- Make code robust and more memory efficient.
v4:
- Replace shell call with platform.uname(). Check file existence
before reading.
v3:
- Add built-in module list in loaded_modules for checking
instead of removing error check.
v2:
- fix git commit description style in commit log
- fix typo spelling
---
Apologies for the delay.
Reviewed-by: Anatoly Burakov <anatoly.bura...@intel.com>
--
Thanks,
Anatoly
