On Tue, Feb 09, 2021 at 12:07:13PM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- > > From: Bruce Richardson <bruce.richard...@intel.com> > > Sent: Tuesday, February 9, 2021 12:51 PM > > To: Juraj Linkeš <juraj.lin...@pantheon.tech> > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com; > > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > > dev@dpdk.org > > Subject: Re: [PATCH v5] build: kni cross-compilation support > > <snip> > > > + description: 'Path to the kernel for building kernel modules. > > > +Headers must be in $kernel_dir. Modules will be installed in > > > +/lib/modules/$(uname -r)/extra/dpdk for native builds.') > > > > While correct, the last sentence isn't really relevant to the build option, > > it's more > > an additional note, and it seems a bit awkward. Maybe it can be shortened by > > referencing "/lib/modules" rather than giving the full path. > > Alternatively, maybe just putting the details in the documentation is a > > better > > plan, and leaving the comment here as just "path to the kernel for building > > kernel modules". > > > > Having it in docs would be better, but where exactly? I tried looking, but > didn't find a suitable place. >
It probably should go in the GSG doc, but I agree that there is nowhere obvious for it. I think we could do with the addition of some descriptions of the various options in the GSG, but that is out of the scope of this patch.