On Fri, Feb 05, 2021 at 09:26:05AM +0000, Juraj Linkeš wrote:
>
>
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richard...@intel.com>
> > Sent: Thursday, February 4, 2021 6:34 PM
> > To: Juraj Linkeš <juraj.lin...@pantheon.tech>
> > Cc: tho...@monjalon.net; ruifeng.w...@arm.com;
> > honnappa.nagaraha...@arm.com; jerinjac...@gmail.com;
> > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io;
> > dev@dpdk.org
> > Subject: Re: [RFC PATCH v2] build: kni cross-compilation support
> >
> > On Thu, Feb 04, 2021 at 10:51:41AM +0100, Juraj Linkeš wrote:
> > > The kni linux module is using a custom target for building, which
> > > doesn't take into account any cross compilation arguments. The
> > > arguments in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC,
> > > LD (for clang). Get those from the cross file and pass them to the
> > > custom target.
> > >
> > > The user supplied path may not contain the 'build' directory, such as
> > > when using cross-compiled headers, so only append that in the default
> > > case (when no path is supplied in native builds) and use the
> > > unmodified path from the user otherwise. Also modify the install path
> > accordingly.
> > >
> > > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech>
> >
> > Some comments inline below.
> >
>
> Thanks, these are very helpful.
>
<snip>
> > > + install_dir = ''
> > > + install = false
> >
> > I think these should be defined and initialized further up the file,
> > outside the
> > conditional block.
> >
>
> Ok, I'll make the default true and set it to false in the cross compilation
> case.
>
Can you just initialize the value to !meson.is_cross_build() and leave it
at that?
