On Thu, Jan 28, 2021 at 12:12:44PM +0100, Thomas Monjalon wrote: > 27/01/2021 18:33, Bruce Richardson: > > For CI builds, turn on the checking of includes. > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> Acked-by: > > Aaron Conole <acon...@redhat.com> --- .ci/linux-build.sh | 1 + 1 file > > changed, 1 insertion(+) > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index > > afa3689a09..fdbeb5a616 100755 --- a/.ci/linux-build.sh +++ > > b/.ci/linux-build.sh @@ -57,6 +57,7 @@ fi OPTS="$OPTS > > -Dmachine=default" OPTS="$OPTS --default-library=$DEF_LIB" OPTS="$OPTS > > --buildtype=debugoptimized" +OPTS="$OPTS -Dcheck_includes=true" > > Which percentage of time does it add on GHA? > I'd have to gather some before/after tests to know for sure, but to check it wasn't too heavy-weight I was just monitoring the log at the end of a build on GHA. The specific build I watched took nearly 15 minutes, and I would guess-timate that the extra task took about 20 seconds of that.
- Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chk... Bruce Richardson
- Re: [dpdk-dev] [PATCH v6 6/8] buildtools... David Marchand
- Re: [dpdk-dev] [PATCH v6 6/8] build... Bruce Richardson
- Re: [dpdk-dev] [PATCH v6 6/8] build... Bruce Richardson
- [dpdk-dev] [PATCH v6 7/8] devtools: remove check-inc... Bruce Richardson
- Re: [dpdk-dev] [PATCH v6 7/8] devtools: remove c... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v6 7/8] devtools: remo... Bruce Richardson
- Re: [dpdk-dev] [PATCH v6 7/8] devtools: ... Thomas Monjalon
- [dpdk-dev] [PATCH v6 8/8] ci: add checking of includ... Bruce Richardson
- Re: [dpdk-dev] [PATCH v6 8/8] ci: add checking o... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v6 8/8] ci: add checki... Bruce Richardson
- Re: [dpdk-dev] [PATCH v6 8/8] ci: add ch... Bruce Richardson
- Re: [dpdk-dev] [PATCH v6 8/8] ci: a... David Marchand
- Re: [dpdk-dev] [PATCH v6 8/8] c... Aaron Conole
- Re: [dpdk-dev] [PATCH v6 0/8] add checking of header... David Marchand
- Re: [dpdk-dev] [PATCH v6 0/8] add checking of he... Bruce Richardson
- [dpdk-dev] [PATCH v7 00/10] add checking of header includ... Bruce Richardson
- [dpdk-dev] [PATCH v7 01/10] eal: add missing include... Bruce Richardson
- [dpdk-dev] [PATCH v7 02/10] eal: fix error attribute... Bruce Richardson
- [dpdk-dev] [PATCH v7 03/10] power: fix missing heade... Bruce Richardson
- [dpdk-dev] [PATCH v7 04/10] rib: fix missing header ... Bruce Richardson