On 1/18/2021 9:35 AM, Nalla Pradeep wrote:
Adding bare minimum PMD library and doc build infrastructure
and claim the maintainership for octeontx end point PMD.

Signed-off-by: Nalla Pradeep <pna...@marvell.com>

<...>

@@ -0,0 +1,8 @@
+;
+; Supported features of the 'octeontx_ep' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Linux VFIO           = Y

This feature name has been updated, can you please rebase on top of latest next-net for it.

Also can you please set the supported architectures.

<...>

@@ -0,0 +1,32 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+    Copyright(C) 2020 Marvell.
+
+OCTEON TX EP Poll Mode driver
+===========================
+
+The OCTEON TX EP ETHDEV PMD (**librte_pmd_octeontx_ep**) provides poll mode
+ethdev driver support for the virtual functions (VF) of **Marvell OCTEON TX2**
+and **Cavium OCTEON TX** families of adapters in SR-IOV context.
+
+More information can be found at `Marvell Official Website
+<https://www.marvell.com/embedded-processors/infrastructure-processors>`_.

This link leads to a very generic product page, is there a way to provide the link for the product this driver is for?

+
+Features
+--------
+
+Features of the OCTEON TX EP Ethdev PMD are:
+

Above 'Features' block can be added when a featre is added.

+
+Prerequisites
+-------------
+
+See :doc:`../platform/octeontx2` and `../platform/octeontx` for setup 
information.
+

Since this is a VF driver, there must be a dependency to the PF driver, can you please provide more details on the PF driver. As far as I understand both octeontx & octeontx2 are supported but please give more details about dependency. I assume there must be some host drivers for the endpoint PF, etc..

+Compile time Config Options
+---------------------------
+
+The following options may be modified in the ``config`` file.
+
+- ``CONFIG_RTE_LIBRTE_OCTEONTX_EP_PMD`` (default ``y``)
+
+  Toggle compilation of the ``librte_pmd_octeontx_ep`` driver.

I think the config option is not more exists, please drop it.

<...>

+++ b/drivers/net/octeontx_ep/version.map
@@ -0,0 +1,4 @@
+DPDK_20.0 {

It should be 'DPDK_21'

+
+        local: *;
+};


Reply via email to