Tested-by: Marvin Liu <yong.liu at intel.com>
> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Tuesday, July 21, 2015 1:41 PM > To: Tahhan, Maryam; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats- > >ierrors > > Hi, > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maryam Tahhan > > Sent: Monday, July 20, 2015 8:28 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats- > >ierrors > > > > Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove > > (rxnfgpc - hw_stats->gprc) which does not account for phy errors. > > hw_stats->gprc is the Number of good (non-erred) Rx packets (from the > > network) that pass L2 filtering and has a legal length as defined by > > LongPacketEnable. While rxnfgpc is the Number of good (non-erred with > legal > > length) Rx packets (from the network) regardless of packet filtering and > receive > > enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation > should > > be removed from the calculation of ierrors. > > Validated with testpmd by sending packets to the interface without > forwarding > > enabled - packets should be dropped and the error counters incremented. > > > > v2: > > - specified the commit that this bug fix fixes. > > > > Signed-off-by: Maryam Tahhan <maryam.tahhan at intel.com> > Acked-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
