On 1/18/2021 7:04 AM, Steve Yang wrote:
The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, this
fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead.
When the MTU(1500) set, the frame type of rx packet will be different
if used different overhead, it will cause the consistency issue, and the
normal packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU'
can avoid this issue.
Like,
app -> max_rx_pkt_len = 1500/*mtu*/ + 22/*overhead*/ = 1522
ethdev -> 1522 > 1518/*MAX*/; max_rx_pkt_len = 1518
driver -> MTU = 1518 - 22 = 1496
Packets with size 1497-1500 are dropped although intention is to be able
to send/receive them.
Following scopes will be changed:
- 'rte_ethdev'
- 'app', e.g.: 'test-pmd';
- net PMDs which support VLAN tag(s) within overhead, e.g.: i40e;
Following scopes perhaps will be impacted:
- the cases of jumbo frame related;
- the logic of 'max_rx_pkt_len' and 'mtu' related;
- the using place of 'RTE_ETHER_MAX_LEN';
---
v4:
- moved mtu assignment to the same if-true-block of jumbo frame;
v3:
- removed redundant if-conditions in rte_ethdev and testpmd;
- adjusted the alignment style;
- added offload check before updating mtu;
v2:
- defined the 'RTE_ETHER_MTU + overhead' to 'driver_ETH_MAX_LEN';
- changed the 'mtu > RTE_ETHER_MTU' to 'frame_size > driver_ETH_MAX_LEN';
---
Steve Yang (22):
ethdev: fix MTU size exceeds max rx packet length
app/testpmd: fix max rx packet length for VLAN packets
net/dpaa: fix the jumbo frame flag condition for mtu set
net/dpaa2: fix the jumbo frame flag condition for mtu set
net/e1000: fix the jumbo frame flag condition for mtu set
net/hns3: fix the jumbo frame flag condition for mtu set
net/i40e: fix the jumbo frame flag condition
net/iavf: fix the jumbo frame flag condition
net/ice: fix the jumbo frame flag condition
net/ipn3ke: fix the jumbo frame flag condition for mtu set
net/octeontx: fix the jumbo frame flag condition for mtu set
net/octeontx2: fix the jumbo frame flag condition for mtu
net/qede: fix the jumbo frame flag condition for mtu set
net/sfc: fix the jumbo frame flag condition for mtu set
net/thunderx: fix the jumbo frame flag condition for mtu set
net/ixgbe: fix the jumbo frame flag condition
net/cxgbe: fix the jumbo frame flag condition
net/axgbe: fix the jumbo frame flag condition for mtu set
net/enetc: fix the jumbo frame flag condition for mtu set
net/hinic: fix the jumbo frame flag condition for mtu set
net/nfp: fix the jumbo frame flag condition for mtu set
net/liquidio: fix the jumbo frame flag condition for mtu set
For series,
Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>
Series applied to dpdk-next-net/main, thanks.
