Hi Stephen, I don't think there's a conflict. The message just reminder us that we can adjust the values to achieve better performance. I saw ixgbe and i40e also use 0 as the same default value. To my opinion, it's good to keep the same behavior. Thanks.
> -----Original Message----- > From: Stephen Hemminger [mailto:shemming at brocade.com] > Sent: Friday, July 17, 2015 1:17 AM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: igb PMD should set the default tx wthresh correctly. > > Why doesn't igb driver set the wthresh it wants as default? > > I see: > PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance, > consider setting the TX WTHRESH value to 4, 8, or 16. > > But the default tx_conf has wthresh of 0. > > #define IGB_DEFAULT_TX_WTHRESH 0 > > > Either message should be removed or default TX wthresh should change.
