30/12/2020 09:54, Xueming(Steven) Li: > Hi Andrew, > > From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > >On 12/18/20 5:55 PM, Xueming Li wrote: > >> SubFunction [1] is a portion of the PCI device, a SF netdev has its > >> own dedicated queues(txq, rxq). A SF netdev supports eswitch > >> representation offload similar to existing PF and VF representors. A > >> SF shares PCI level resources with other SFs and/or with its parent PCI > >function. > >> > >> >From SmartNIC perspective, when PCI device is shared for multi-host, > >> representors for host controller and host PF is required. > >> > >> This patch set introduces new representor types in addtion to existing > >> VF representor. Syntax: > >> > >> [[c#]pf#]vf#: VF port representor/s from controller/pf > >> [[c#]pf#]sf#: SF port representor/s from controller/pf > >> #: VF representor - for backwards compatibility > >> > >> "#" is number instance, list or range, valid examples: > >> 1, [1,3,5], [0-3], [0,2-4,6] > >> > >> For flexibility, this patch also introduces new netdev capability to > >> indicate the capability to support new representor types. > > > >Many thanks for sharing the patchset. Looks very interesting. > >I've already sent my comments and questions for individual patches. > > Appreciate for the wonderful review, will address them next week.
I agree, good review, thanks. I am waiting for a v2.
