> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, July 16, 2015 1:26 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port > > 2015-07-16 13:19, Cristian Dumitrescu: > > +* librte_port (rte_port.h): Macros to access the packet meta-data stored > within > > + the packet buffer will be adjusted to cover the packet mbuf structure as > well, > > + as currently they are able to access any packet buffer location except > > the > > + packet mbuf structure. The consequence is that applications currently > using > > + these macros will have to adjust the value of the offset parameter of > these > > + macros by increasing it with sizeof(struc rte_mbuf). The affected macros > are: > > + RTE_MBUF_METADATA_UINT<8, 16, 32, 64>_PTR and > > + RTE_MBUF_METADATA_UINT<8, 16, 32, 64>. In terms of code changes, > most likely > > + only the definition of RTE_MBUF_METADATA_UINT8_PTR macro will be > changed from > > + ``(&((uint8_t *) &(mbuf)[1])[offset])`` to > > + ``(&((uint8_t *) (mbuf))[offset])``. > > Cristian, > General comment: you are too verbose :) > Specifically on this patch: same comment ;)
No problem, will simplify and resend. Thanks, Thomas.
