>-----Original Message----- >From: Steve Yang <stevex.y...@intel.com> >Sent: Thursday, December 17, 2020 2:53 PM >To: dev@dpdk.org >Cc: wenzhuo...@intel.com; beilei.x...@intel.com; >bernard.iremon...@intel.com; asoma...@amd.com; >rahul.lakkire...@chelsio.com; hemant.agra...@nxp.com; >sachin.sax...@oss.nxp.com; jia....@intel.com; haiyue.w...@intel.com; >g.si...@nxp.com; xuanziya...@huawei.com; >cloud.wangxiao...@huawei.com; zhouguoy...@huawei.com; >xavier.hu...@huawei.com; humi...@huawei.com; >yisen.zhu...@huawei.com; ouli...@huawei.com; jingjing...@intel.com; >qiming.y...@intel.com; qi.z.zh...@intel.com; rosen...@intel.com; Shijith >Thotton <sthot...@marvell.com>; Srisivasubramanian Srinivasan ><sriniva...@marvell.com>; heinrich.k...@netronome.com; Harman Kalra ><hka...@marvell.com>; Jerin Jacob Kollanukkaran <jer...@marvell.com>; >Nithin Kumar Dabilpuram <ndabilpu...@marvell.com>; Kiran Kumar >Kokkilagadda <kirankum...@marvell.com>; Rasesh Mody ><rm...@marvell.com>; Shahed Shaikh <shsha...@marvell.com>; >andrew.rybche...@oktetlabs.ru; Maciej Czekaj [C] <mcze...@marvell.com>; >tho...@monjalon.net; ferruh.yi...@intel.com; ivan.bo...@6wind.com; >konstantin.anan...@intel.com; samuel.gauth...@6wind.com; >david.march...@6wind.com; shah...@mellanox.com; >step...@networkplumber.org; maxime.coque...@redhat.com; >olivier.m...@6wind.com; lihuis...@huawei.com; shreyansh.j...@nxp.com; >wei....@intel.com; fengchuns...@huawei.com; chenhao...@huawei.com; >tangchengch...@hisilicon.com; helin.zh...@intel.com; >yanglong...@intel.com; xiaolong...@intel.com; ting...@intel.com; >xiaoyun...@intel.com; dan....@intel.com; andy....@intel.com; Vamsi >Krishna Attunuru <vattun...@marvell.com>; Sunil Kumar Kori ><sk...@marvell.com>; sony.cha...@qlogic.com; >bruce.richard...@intel.com; ivan.ma...@oktetlabs.ru; r...@semihalf.com; >slawomir.ro...@semihalf.com; kamil.rytarow...@caviumnetworks.com; >wei.zh...@intel.com; junyux.ji...@intel.com; kuma...@chelsio.com; >girish.nandibasa...@amd.com; rolf.neugeba...@netronome.com; >alejandro.luc...@netronome.com; Steve Yang <stevex.y...@intel.com> >Subject: [EXT] [PATCH v2 12/22] net/octeontx2: fix the jumbo frame flag >condition for mtu > >External Email > >---------------------------------------------------------------------- >The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but >the Ether overhead is larger than 18 when it supports dual VLAN tags. >That will cause the jumbo flag rx offload is wrong when MTU size is >'RTE_ETHER_MTU'. > >This fix will change the boundary condition with 'RTE_ETHER_MTU' and >overhead. > >Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation") > >Signed-off-by: Steve Yang <stevex.y...@intel.com> >--- > drivers/net/octeontx2/otx2_ethdev.h | 2 ++ > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/octeontx2/otx2_ethdev.h >b/drivers/net/octeontx2/otx2_ethdev.h >index 3b9871f4dc..99f0469d89 100644 >--- a/drivers/net/octeontx2/otx2_ethdev.h >+++ b/drivers/net/octeontx2/otx2_ethdev.h >@@ -51,6 +51,8 @@ > /* ETH_HLEN+ETH_FCS+2*VLAN_HLEN */ > #define NIX_L2_OVERHEAD \ > (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + 8) >+#define NIX_L2_MAX_LEN \ >+ (RTE_ETHER_MTU + NIX_L2_OVERHEAD) > > /* HW config of frame size doesn't include FCS */ > #define NIX_MAX_HW_FRS 9212 >diff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c >b/drivers/net/octeontx2/otx2_ethdev_ops.c >index b36d37b9f7..963cc285ed 100644 >--- a/drivers/net/octeontx2/otx2_ethdev_ops.c >+++ b/drivers/net/octeontx2/otx2_ethdev_ops.c >@@ -58,7 +58,7 @@ otx2_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t >mtu) > if (rc) > return rc; > >- if (frame_size > RTE_ETHER_MAX_LEN) >+ if (frame_size > NIX_L2_MAX_LEN) > dev->rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; > else > dev->rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; >-- >2.17.1
Acked-by: Sunil Kumar Kori <sk...@mavell.com>