Hi, steve What I saw is that you replace of frame size checking to mtu checking, but you still use "18" as overhead number to configure max_rx_pkt_len? uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size; > -----Original Message----- > From: Steve Yang <[email protected]> > Sent: Wednesday, December 9, 2020 11:16 AM > To: [email protected] > Cc: [email protected]; [email protected]; Guo, Jia > <[email protected]>; Wang, Haiyue <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected]; Xing, Beilei > <[email protected]>; Wu, Jingjing <[email protected]>; Yang, Qiming > <[email protected]>; Zhang, Qi Z <[email protected]>; Xu, Rosen > <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Yigit, Ferruh > <[email protected]>; [email protected]; Zhang, Helin > <[email protected]>; Ananyev, Konstantin > <[email protected]>; [email protected]; > [email protected]; Xu, Ting <[email protected]>; Li, Xiaoyun > <[email protected]>; Lu, Wenzhuo <[email protected]>; Pei, Andy > <[email protected]>; Wei, Dan <[email protected]>; [email protected]; > [email protected]; [email protected]; Richardson, Bruce > <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; Yang, SteveX <[email protected]> > Subject: [PATCH v1 00/12] fix rx packets dropped issue > > The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, > this fix will change the boundary condition with 'RTE_ETHER_MTU'. > > When the MTU(1500) set, the frame type of rx packet will be different if > used different overhead, it will cause the consistency issue, and the normal > packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU' > can avoid this issue. > > Following scopes will be changed: > - 'rte_ethdev' > - 'app', e.g.: 'test-pmd'; > - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e; > > Steve Yang (12): > net/dpaa2: fix the jumbo frame flag condition for mtu set > net/e1000: fix the jumbo frame flag condition for mtu set > net/hns3: fix the jumbo frame flag condition for mtu set > net/i40e: fix the jumbo frame flag condition > net/iavf: fix the jumbo frame flag condition > net/ice: fix the jumbo frame flag condition > net/ipn3ke: fix the jumbo frame flag condition for mtu set > net/octeontx: fix the jumbo frame flag condition for mtu set > net/octeontx2: fix the jumbo frame flag condition for mtu > net/qede: fix the jumbo frame flag condition for mtu set > net/sfc: fix the jumbo frame flag condition for mtu set > net/thunderx: fix the jumbo frame flag condition for mtu set > > drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- > drivers/net/e1000/em_ethdev.c | 2 +- > drivers/net/e1000/igb_ethdev.c | 2 +- > drivers/net/hns3/hns3_ethdev.c | 2 +- > drivers/net/hns3/hns3_ethdev_vf.c | 2 +- > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_ethdev.h | 1 + > drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- > drivers/net/i40e/i40e_fdir.c | 2 +- > drivers/net/i40e/i40e_rxtx.c | 8 ++++---- > drivers/net/iavf/iavf.h | 1 + > drivers/net/iavf/iavf_ethdev.c | 10 +++++----- > drivers/net/ice/ice_dcf_ethdev.c | 8 ++++---- > drivers/net/ice/ice_ethdev.c | 2 +- > drivers/net/ice/ice_ethdev.h | 1 + > drivers/net/ice/ice_rxtx.c | 10 +++++----- > drivers/net/ipn3ke/ipn3ke_representor.c | 2 +- > drivers/net/octeontx/octeontx_ethdev.c | 2 +- > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > drivers/net/qede/qede_ethdev.c | 2 +- > drivers/net/sfc/sfc_ethdev.c | 2 +- > drivers/net/thunderx/nicvf_ethdev.c | 2 +- > 22 files changed, 40 insertions(+), 37 deletions(-) > > -- > 2.17.1
