Hi, steve

What I saw is that you replace of frame size checking to mtu checking, but you 
still use
"18" as overhead number to configure max_rx_pkt_len?
 
uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;

dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;

> -----Original Message-----
> From: Steve Yang <stevex.y...@intel.com>
> Sent: Wednesday, December 9, 2020 11:16 AM
> To: dev@dpdk.org
> Cc: hemant.agra...@nxp.com; sachin.sax...@oss.nxp.com; Guo, Jia
> <jia....@intel.com>; Wang, Haiyue <haiyue.w...@intel.com>;
> xavier.hu...@huawei.com; humi...@huawei.com;
> yisen.zhu...@huawei.com; ouli...@huawei.com; Xing, Beilei
> <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Xu, Rosen
> <rosen...@intel.com>; hka...@marvell.com; jer...@marvell.com;
> ndabilpu...@marvell.com; kirankum...@marvell.com;
> rm...@marvell.com; shsha...@marvell.com;
> andrew.rybche...@oktetlabs.ru; mcze...@marvell.com; wei....@intel.com;
> fengchuns...@huawei.com; lihuis...@huawei.com; Yigit, Ferruh
> <ferruh.yi...@intel.com>; chenhao...@huawei.com; Zhang, Helin
> <helin.zh...@intel.com>; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; yanglong...@intel.com;
> xiaolong...@intel.com; Xu, Ting <ting...@intel.com>; Li, Xiaoyun
> <xiaoyun...@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com>; Pei, Andy
> <andy....@intel.com>; Wei, Dan <dan....@intel.com>; sk...@marvell.com;
> vattun...@marvell.com; sony.cha...@qlogic.com; Richardson, Bruce
> <bruce.richard...@intel.com>; ivan.ma...@oktetlabs.ru;
> zyta.sz...@semihalf.com; slawomir.ro...@semihalf.com;
> r...@semihalf.com; Yang, SteveX <stevex.y...@intel.com>
> Subject: [PATCH v1 00/12] fix rx packets dropped issue
> 
> The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition,
> this fix will change the boundary condition with 'RTE_ETHER_MTU'.
> 
> When the MTU(1500) set, the frame type of rx packet will be different if
> used different overhead, it will cause the consistency issue, and the normal
> packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU'
> can avoid this issue.
> 
> Following scopes will be changed:
> - 'rte_ethdev'
> - 'app', e.g.: 'test-pmd';
> - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e;
> 
> Steve Yang (12):
>   net/dpaa2: fix the jumbo frame flag condition for mtu set
>   net/e1000: fix the jumbo frame flag condition for mtu set
>   net/hns3: fix the jumbo frame flag condition for mtu set
>   net/i40e: fix the jumbo frame flag condition
>   net/iavf: fix the jumbo frame flag condition
>   net/ice: fix the jumbo frame flag condition
>   net/ipn3ke: fix the jumbo frame flag condition for mtu set
>   net/octeontx: fix the jumbo frame flag condition for mtu set
>   net/octeontx2: fix the jumbo frame flag condition for mtu
>   net/qede: fix the jumbo frame flag condition for mtu set
>   net/sfc: fix the jumbo frame flag condition for mtu set
>   net/thunderx: fix the jumbo frame flag condition for mtu set
> 
>  drivers/net/dpaa2/dpaa2_ethdev.c        |  2 +-
>  drivers/net/e1000/em_ethdev.c           |  2 +-
>  drivers/net/e1000/igb_ethdev.c          |  2 +-
>  drivers/net/hns3/hns3_ethdev.c          |  2 +-
>  drivers/net/hns3/hns3_ethdev_vf.c       |  2 +-
>  drivers/net/i40e/i40e_ethdev.c          |  2 +-
>  drivers/net/i40e/i40e_ethdev.h          |  1 +
>  drivers/net/i40e/i40e_ethdev_vf.c       | 10 +++++-----
>  drivers/net/i40e/i40e_fdir.c            |  2 +-
>  drivers/net/i40e/i40e_rxtx.c            |  8 ++++----
>  drivers/net/iavf/iavf.h                 |  1 +
>  drivers/net/iavf/iavf_ethdev.c          | 10 +++++-----
>  drivers/net/ice/ice_dcf_ethdev.c        |  8 ++++----
>  drivers/net/ice/ice_ethdev.c            |  2 +-
>  drivers/net/ice/ice_ethdev.h            |  1 +
>  drivers/net/ice/ice_rxtx.c              | 10 +++++-----
>  drivers/net/ipn3ke/ipn3ke_representor.c |  2 +-
> drivers/net/octeontx/octeontx_ethdev.c  |  2 +-
> drivers/net/octeontx2/otx2_ethdev_ops.c |  2 +-
>  drivers/net/qede/qede_ethdev.c          |  2 +-
>  drivers/net/sfc/sfc_ethdev.c            |  2 +-
>  drivers/net/thunderx/nicvf_ethdev.c     |  2 +-
>  22 files changed, 40 insertions(+), 37 deletions(-)
> 
> --
> 2.17.1

Reply via email to