08/12/2020 16:22, Kinsella, Ray: > > On 07/12/2020 17:32, Thomas Monjalon wrote: > > The scripts gen-abi.sh and check-abi.sh are updated > > to print error messages to stderr so they are likely never ignored. > > > > When called from test-meson-builds.sh, the standard messages on stdout > > can be more quiet depending on the verbosity settings. > > The beginning of the ABI check is announced in verbose mode. > > The commands are printed in very verbose mode. > > The check result details are available in verbose mode. > > So there is a bit of a disconnect here - you change gen-abi/check-abi to > correctly direct errors to sterr. > > You then however provide a method to ignore them in test_meson_build.sh. > I thinking giving people a way of ignoring the indicated lines below, > is a bad plan. > > No problem with the changes to check-abi/gen-abi - but I think the changes > to test_meson_build.sh are a bad idea.
No the errors are not ignored. Only stdout (report details) is redirected. > > $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \ > > - $(readlink -f $builds_dir/$targetdir/install) > > + $(readlink -f $builds_dir/$targetdir/install) >&$verbose
