> -----Original Message----- > From: Ferruh Yigit <ferruh.yi...@intel.com> > Sent: Thursday, November 26, 2020 2:23 PM > Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action > attribute > > One small point, I know it was mention in some thread, can we also > deprecate the id? > > Maybe the entire struct? since there is not need for configuration any more. > > > > There is alternative usage for 'shared' fields, that is the reason of the > deprecation. But there are some usage of the 'id' without alternative, we can > discuss if that usage is right or wrong later, but for now I think better to > start with just this patch. > > And if 'id' also decided to be deprecated later, yes we can remove entire > struct > in that case.
Acked-by: Ori Kam <or...@nvidia.com> Thanks, Ori