On 7/9/2015 11:32 AM, Tetsuya Mukawa wrote: > On 2015/07/08 18:59, Thomas Monjalon wrote: >> 2015-07-08 09:49, Iremonger, Bernard: >>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >>>> On 2015/07/07 19:53, Iremonger, Bernard wrote: >>>>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >>>>>> On 2015/07/06 20:35, Qiu, Michael wrote: >>>>>>> Hi, all >>>>>>> >>>>>>> As we has gap on the memory release action to be done in which step, >>>>>>> I appreciate all your comments on this patch. >>>>>>> >>>>>>> Currently, the correct quit sequence for testpmd is stop() ---> >>>>>>> port_stop() --> port_close() --> quit(). This will lead lots of >>>>>>> memory not released by default, like queues.
[.../...] >> It appears that the API is not defined. >> None of these assumptions is written in rte_ethdev.h. >> Please continue the discussion by submitting a patch fixing the doxygen >> comments of these functions. >> How an application developper is supposed to use these functions without >> having a clear explanation of their roles in doxygen? > Yes, this assumption is only written in DPDK user's guide. > So we should add description to doxygen. I will take care of it. > > Anyway, I will add description to doxygen like user's guide. > (A) stop() and close() must be called before detach(). > (B) close() releases all most all resources. > Probably Bernard and Michael patches are fit for above restrictions. > > It may be good to add below in DPDK-2.2, though supporting below feature > will be more user friendly. > (C) Even if stop() and close() are not called, detach() will take care > of it. > > Probably, it's not so much time left before releasing DPDK-2.1. > So how about keeping current restriction written in user's guide, then > add a new feature in DPDK-2.2. Yes, agree. Thanks, Michael > Regards, > Tetsuya >
