Tested-by: Xie,WeiX < weix....@intel.com> Regards, Xie Wei
> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Murphy Yang > Sent: Monday, November 23, 2020 3:05 PM > To: dev@dpdk.org > Cc: Yang, Qiming <qiming.y...@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; Yang, SteveX <stevex.y...@intel.com>; Yang, > MurphyX <murphyx.y...@intel.com> > Subject: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum > error > > If enable hardware outer UDP TX offload checksum, it doesn't take effect > when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum. > > In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' > equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can > calculate the outer tunneling UDP checksum. > > Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel") > > Signed-off-by: Murphy Yang <murphyx.y...@intel.com> > --- > drivers/net/ice/ice_rxtx.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index > 5fbd68eafc..9769e216bf 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags, > *cd_tunneling |= (tx_offload.l2_len >> 1) << > ICE_TXD_CTX_QW0_NATLEN_S; > > - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) && > - (ol_flags & PKT_TX_OUTER_IP_CKSUM) && > + /** > + * Calculate the tunneling UDP checksum. > + * Shall be set only if L4TUNT = 01b and EIPT is not zero > + */ > + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) && > (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING)) > *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M; } > -- > 2.17.1
