12/11/2020 14:41, wangyunjian: > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > > On 12-Nov-20 9:31 AM, wangyunjian wrote: > > > From: Yunjian Wang <wangyunj...@huawei.com> > > > > > > Cleanup code style issue reported by kernel checkpatch. As follows: > > > * ERROR:CODE_INDENT: code indent should use tabs where possible > > > * ERROR:SPACING: spaces required around that '?' (ctx:VxE) > > > * WARNING:INDENTED_LABEL: labels should not be indented > > > > > > Fixes: b0489e7bca2f ("malloc: fix linear complexity") > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Yunjian Wang <wangyunj...@huawei.com> > > > --- > > > --- a/lib/librte_eal/common/malloc_elem.c > > > +++ b/lib/librte_eal/common/malloc_elem.c > > > @@ -391,14 +391,14 @@ malloc_elem_free_list_index(size_t size) > > > return 0; > > > > > > /* Find next power of 2 >= size. */ > > > - log2 = sizeof(size) * 8 - __builtin_clzl(size-1); > > > + log2 = sizeof(size) * 8 - __builtin_clzl(size - 1); > > > > > > /* Compute freelist index, based on log2(size). */ > > > index = (log2 - MALLOC_MINSIZE_LOG2 + > > MALLOC_LOG2_INCREMENT - 1) / > > > - MALLOC_LOG2_INCREMENT; > > > + MALLOC_LOG2_INCREMENT; > > > > Here and below, I believe we usually add two indents to the continuation > > line, to avoid confusing with things like if statements. > > It is already two indents in the patch. Please double check?
No it is two indents from the beginning of the line, while Anatoly was asking for double additional indent. > > With that fixed, I fix it. > > Acked-by: Anatoly Burakov <anatoly.bura...@intel.com> Applied, thanks
