2015-07-13 16:25, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2015-07-10 00:31, Helin Zhang:
> > > As unified packet types are used instead, those old bit masks and the
> > > relevant macros for packet type indication need to be removed.
> >
> > It breaks mlx4 and cxgbe drivers.
[...]
> I think I have already reworked with that changes in v9 and v10 recently.
> http://www.dpdk.org/dev/patchwork/patch/6253/
No, your changes were for t4_ethrx_handler().
Since recent cxgbe change, we also need to update process_responses().
> > The cxgbe changes need to be updated after
> > 78fc1a716ae8 ("cxgbe: improve Rx performance") I suggest this update:
> >
> > --- a/drivers/net/cxgbe/sge.c
> > +++ b/drivers/net/cxgbe/sge.c
> > @@ -1419,7 +1419,11 @@ static int process_responses(struct sge_rspq *q, int
> > budget,
> > unmap_rx_buf(&rxq->fl);
> >
> > if (cpl->l2info & htonl(F_RXF_IP)) {
> > +#ifdef RTE_NEXT_ABI
> > + mbuf->packet_type = RTE_PTYPE_L3_IPV4;
> > +#else
> > pkt->ol_flags |= PKT_RX_IPV4_HDR;
> > +#endif
> > if (unlikely(!csum_ok))
> > pkt->ol_flags |=
> > PKT_RX_IP_CKSUM_BAD;
> >
> > @@ -1427,7 +1431,11 @@ static int process_responses(struct sge_rspq *q, int
> > budget,
> > htonl(F_RXF_UDP | F_RXF_TCP))
> > && !csum_ok)
> > pkt->ol_flags |=
> > PKT_RX_L4_CKSUM_BAD;
> > } else if (cpl->l2info & htonl(F_RXF_IP6)) {
> > +#ifdef RTE_NEXT_ABI
> > + mbuf->packet_type = RTE_PTYPE_L3_IPV6;
> > +#else
> > pkt->ol_flags |= PKT_RX_IPV6_HDR;
> > +#endif
> > }
>
