OK, please reject this patch. Thanks, Yunjian
> -----Original Message----- > From: Suanming Mou [mailto:suanmi...@nvidia.com] > Sent: Wednesday, November 18, 2020 10:16 AM > To: wangyunjian <wangyunj...@huawei.com>; dev@dpdk.org > Cc: ma...@mellanox.com; shah...@mellanox.com; > viachesl...@mellanox.com; Lilijun (Jerry) <jerry.lili...@huawei.com>; xudingke > <xudin...@huawei.com> > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove unnecessary NULL check > > Hi Yunjian, > > As the code changed, I think this patch is not needed anymore. > > Thanks, > SuanmingMou > > On 3/31/2020 6:24 PM, wangyunjian wrote: > > From: Yunjian Wang <wangyunj...@huawei.com> > > > > This NULL check is unnecessary, container_of is never NULL. > > > > Signed-off-by: Yunjian Wang <wangyunj...@huawei.com> > > --- > > drivers/net/mlx5/mlx5.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > > 94aaa6057..2e4edb123 100644 > > --- a/drivers/net/mlx5/mlx5.c > > +++ b/drivers/net/mlx5/mlx5.c > > @@ -747,7 +747,6 @@ mlx5_free_table_hash_list(struct mlx5_priv *priv) > > if (pos) { > > tbl_data = container_of(pos, struct mlx5_flow_tbl_data_entry, > > entry); > > - MLX5_ASSERT(tbl_data); > > mlx5_hlist_remove(sh->flow_tbls, pos); > > rte_free(tbl_data); > > } > > @@ -756,7 +755,6 @@ mlx5_free_table_hash_list(struct mlx5_priv *priv) > > if (pos) { > > tbl_data = container_of(pos, struct mlx5_flow_tbl_data_entry, > > entry); > > - MLX5_ASSERT(tbl_data); > > mlx5_hlist_remove(sh->flow_tbls, pos); > > rte_free(tbl_data); > > } > > @@ -766,7 +764,6 @@ mlx5_free_table_hash_list(struct mlx5_priv *priv) > > if (pos) { > > tbl_data = container_of(pos, struct mlx5_flow_tbl_data_entry, > > entry); > > - MLX5_ASSERT(tbl_data); > > mlx5_hlist_remove(sh->flow_tbls, pos); > > rte_free(tbl_data); > > } >
