On 11/13/2020 2:02 PM, Ferruh Yigit wrote:
On 11/13/2020 1:13 PM, Olivier Matz wrote:
On Fri, Nov 13, 2020 at 11:39:57AM +0100, Olivier Matz wrote:
In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the
pcap pmd is created in a secondary process (this is the case for pdump),
it cannot be registered because this is not allowed from a secondary
process.
To ensure that the field is properly registered, do it from probe()
instead of configure(). Indeed, probe() is invoked on the primary
process when a device is created in a secondary.
probe() invoked first in the primary, later in the secondary, both process calls
the driver probe(). But for this case probe(), and dynfield register, being
called first in primary seems solving the problem.
Would you be OK to change last sentences as:
"Indeed, probe() is first invoked on the primary process when a device is
created in a secondary, this enables registering dynfield from secondary process."
Bugzilla ID: 571
Fixes: d23d73d088c1 ("net/pcap: switch Rx timestamp to dynamic mbuf field")
Signed-off-by: Olivier Matz <olivier.m...@6wind.com>
Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>
Applied to dpdk-next-net/main, thanks.
With above suggested change in the commit log.
