On 11/11/2020 6:49 AM, Jiawen Wu wrote:
Add macsec register enable and setting reset operations.
Add macsec offload suuport.

Signed-off-by: Jiawen Wu <jiawe...@trustnetic.com>

<...>

@@ -1763,6 +1767,10 @@ txgbe_dev_start(struct rte_eth_dev *dev)
         */
        txgbe_dev_link_update(dev, 0);
+ /* setup the macsec ctrl register */
+       if (macsec_setting->offload_en)
+               txgbe_dev_macsec_register_enable(dev, macsec_setting);
+

Is there any piece of code that sets 'offload_en'? This looks like all new added code is dead code and not called at all...

<...>

+++ b/drivers/net/txgbe/txgbe_rxtx.c
@@ -56,6 +56,9 @@ static const u64 TXGBE_TX_OFFLOAD_MASK = (PKT_TX_IP_CKSUM |
                PKT_TX_L4_MASK |
                PKT_TX_TCP_SEG |
                PKT_TX_TUNNEL_MASK |
+#ifdef RTE_LIBRTE_MACSEC
+               PKT_TX_MACSEC |
+#endif

Where this macro defined? Who enables it?

Reply via email to