On Wed, Nov 11, 2020 at 4:54 PM Bruce Richardson <bruce.richard...@intel.com> wrote: > > On Wed, Nov 11, 2020 at 04:45:25PM +0100, David Marchand wrote: > > On Wed, Nov 11, 2020 at 4:40 PM Marvin Liu <yong....@intel.com> wrote: > > > > > > Data prefetch instruction can preload data into cpu’s hierarchical > > > cache before data access. Virtio datapath utilized this feature for > > > data access acceleration. As config RTE_PMD_PACKET_PREFETCH was > > > discarded, now packet data prefetch is enabled based on architecture. > > > > IIUC, this config item was set for all architectures under make compilation. > > > > $ git grep RTE_PMD_PACKET_PREFETCH v20.08 config/ > > v20.08:config/common_base:CONFIG_RTE_PMD_PACKET_PREFETCH=y > > > > Now that we switched to meson, it got lost and this patch only > > restores it for x86. > > Can other architectures check this? > > > If it was globally enabled before, it probably should just be added to > config/rte_config.h file. >
Restoring globally is the probably the best fix, yes. I am still surprised nobody but x86 testers caught a perf regression. -- David marchand
