[dpdk-dev] [PATCH v2] net/txgbe: return changed to fix gcc compile error

[Conor Walsh]

When DPDK is compiled with gcc 7.5 with the optimization level set to 1
gcc sees the offset variable in txgbe_ethdev.c as possibly being
uninitialised. To correct this the final return statement in
txgbe_get_offset_by_id was simplified to return -1.

Signed-off-by: Conor Walsh <conor.wa...@intel.com>
---
 drivers/net/txgbe/txgbe_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 9f533603a1..f8dffe1f12 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -2140,9 +2140,8 @@ txgbe_get_offset_by_id(uint32_t id, uint32_t *offset)
                        nb * (TXGBE_NB_QP_STATS * sizeof(uint64_t));
                return 0;
        }
-       id -= TXGBE_NB_QP_STATS * TXGBE_MAX_QP;
 
-       return -(int)(id + 1);
+       return -1;
 }
 
 static int txgbe_dev_xstats_get_names(struct rte_eth_dev *dev,
-- 
2.25.1