On 11/9/2020 5:44 PM, Ferruh Yigit wrote:
On 11/9/2020 9:49 AM, Zhang, Qi Z wrote:


-----Original Message-----
From: dev <dev-boun...@dpdk.org> On Behalf Of Guo, Jia
Sent: Monday, November 9, 2020 2:24 PM
To: Prateek Agarwal <prate...@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern
"C". Library headers work directly in cpp code. Linking errors thrown due to the
absence of this change in i40e pmd header does not help in resolving the
problem. I needed this header d...

Hi, Agarwal

-----Original Message-----
From: Prateek Agarwal <prate...@gmail.com>
Sent: Saturday, November 7, 2020 5:01 PM
To: Guo, Jia <jia....@intel.com>
Cc: dev@dpdk.org; Prateek Agarwal <prate...@gmail.com>
Subject: [PATCH] Made i40 header CPP compatible using extern "C".
Library headers work directly in cpp code. Linking errors thrown due
to the absence of this change in i40e pmd header does not help in
resolving the problem. I needed this header directly to use...


Obviously that is not you want to merge the title and the commit log. Please
separate it and update one new version.


Fixed the format during merge as below

net/i40e: add extern "C" for cpp compile

Add extern "C" in rte_pmd_i40e.h when be compiled with cpp.

Applied to dpdk-next-net-intel.


Hi Prateek,

In the git history, we have your name as:
"Prateek Agarwal <pratee...@cse.iitb.ac.in>"

We are trying to keep authors unique in the git history, as much as possible, will be OK to continue with the one in the git history?

Using the one in the git history, thanks.

Reply via email to