On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote:
> PKG_CONFIG_PATH is specific to each target, so it must be empty
> before configuring each build from the file according to DPDK_TARGET.
> Inheriting a default PKG_CONFIG_PATH for all targets does not make sense
> and is prone to confusion.
>
> DPDK_MESON_OPTIONS might take a global initial value from environment
> to customize a build test from the shell. Example:
> DPDK_MESON_OPTIONS="b_lto=true"
> Some target-specific options can be added in the configuration file:
> DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL"
>
> Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> ---
Patch looks fine, but I think the log (and comments in the code too,
perhaps) should make it clear that the PKG_CONFIG_PATH can be set in the
local config file, to make it available to the script.
/Bruce
