On 11/6/20 4:24 AM, Cheng Jiang wrote:
> Add args length check before copying to fix the coverity issue.
>
> Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing")
> Coverity issue: 363741
>
> Signed-off-by: Cheng Jiang <cheng1.ji...@intel.com>
> ---
> examples/vhost/main.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 59a1aff07c..ec88874d16 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -634,6 +634,12 @@ us_vhost_parse_args(int argc, char **argv)
>
> if (!strncmp(long_option[option_index].name,
> "dma-type", MAX_LONG_OPT_SZ)) {
> + if (strlen(optarg) >= MAX_LONG_OPT_SZ) {
> + RTE_LOG(INFO, VHOST_CONFIG,
> + "Wrong DMA type\n");
> + us_vhost_usage(prgname);
> + return -1;
> + }
> strcpy(dma_type, optarg);
> }
>
>
Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>
Thanks,
Maxime
