06/11/2020 20:56, Honnappa Nagarahalli: > > 06/11/2020 19:21, Honnappa Nagarahalli: > > > > 05/11/2020 09:55, Jiawen Wu: > > > > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > > > > When pulling in the main branch, I see some checkpatches > > > > > > > > warnings (in order of criticality): > > > > > > > > Using rte_smp_[r/w]mb > > > > > > > > Using rte_panic/rte_exit > > > > > > > > Using compiler attribute directly > > > > > > > > > > > > > > > > Please could you fix them (at least first two) before the second > > series? > > > > > > Thomas, IMO, these should result in errors in checkpatch, not just > > > warnings. > > > Do you see any issues? > > > > The problem is that there are too many false positives in checkpatch. > > These two, mentioned above, should be pretty straight forward.
Yes > Have you seen any false positives with these> No What do you propose to distinguish warnings and errors in patchwork? We can have a different return value in the script to categorize the checkpatch test in the right patchwork column.
