On Fri, Nov 06, 2020 at 05:56:10PM +0100, Thomas Monjalon wrote:
> From: Bruce Richardson <bruce.richard...@intel.com>
>
> It's reasonably common for patches to have issues when built on 32-bits, so
> to prevent this, we can add a 32-bit build (if supported) to the
> "test-meson-builds.sh" script. The tricky bit is using a valid
> PKG_CONFIG_LIBDIR, so for now we use two common possibilities for where that
> should point to in order to get a successful build.
>
> Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> ---
> v3: unset override
> move and rename override
> split command in check_cc_flags
> use check_cc_flags for x86 default build
> v2: added separate flag checking function
> added override of the DPDK_TARGET value
> added /usr/lib32 as possible 32-bit libdir
> ---
> devtools/test-meson-builds.sh | 32 +++++++++++++++++++++++++++++---
> 1 file changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index a87de635a2..ac76c2184b 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -43,6 +43,12 @@ default_cppflags=$CPPFLAGS
> default_cflags=$CFLAGS
> default_ldflags=$LDFLAGS
>
> +check_cc_flags () # <flag to check> <flag2> ...
> +{
> + echo 'int main(void) { return 0; }' |
> + cc $@ -x c - -o /dev/null 2> /dev/null
Minor nit, as a continuation of the previous line, I think this should be
further indented.
Otherwise all looks good to me. Thanks for the updated changes.
/Bruce
