Hi, > -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Matan Azrad > Sent: Tuesday, November 3, 2020 8:49 AM > To: Slava Ovsiienko <viachesl...@nvidia.com> > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state > > The Tx queue stop API doesn't call the PMD callback when the state of > the queue is stopped. > The drivers should update the state to be stopped when the queue stop > callback is done successfully or when the port is stopped. > The drivers should update the state to be started when the queue start > callback is done successfully or when the port is started. > > The driver wrongly didn't update the state to be started when the port > start callback was done what remained the state as stopped. > Following call to a queue stop API was not completed by ethdev layer > because the state is already stopped. > > Move the state update from the Tx queue setup to the port start > callback. > > Fixes: 161d103b231c ("net/mlx5: add queue start and stop") > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad <ma...@nvidia.com> > --- > drivers/net/mlx5/linux/mlx5_verbs.c | 1 + > drivers/net/mlx5/mlx5_devx.c | 1 + > drivers/net/mlx5/mlx5_rxq.c | 4 +++- > drivers/net/mlx5/mlx5_trigger.c | 1 + > drivers/net/mlx5/mlx5_txq.c | 3 +-- > 5 files changed, 7 insertions(+), 3 deletions(-)
Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh