2015-07-10 10:11, Bruce Richardson: > On Thu, Jul 09, 2015 at 05:54:30PM +0100, Pablo de Lara wrote: > > Add new unit test for calculating the average table utilization, > > using random keys, based on number of entries that can be added > > until we encounter one that cannot be added (bucket if full). > > > > Also, replace current hash_perf unit test to see performance more clear. > s/clear/clearly/ > > > The current hash_perf unit test takes too long and add keys that > > may or may not fit in the table and look up/delete that may not be > > in the table. This new unit test gets a set of keys that we know > > that fits in the table, and then measure the time to add/look up/delete > > them. > > > > Mind that performance numbers include time to take a random key > s/Mind/Note/ > > > from a pre-made array of keys, plus a quick check of return value. > > Also, as stated above, expect higher numbers, as all operations > > in the new unit tests will be successful, which means that > > it will take more time, than mixing both successful and unsuccesful > > operations. > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com> > > Looks good, Pablo. > Thomas, perhaps you could make the above minor changes to > the commit log when applying the patch. > > Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Applied with above comments, thanks
