On Thu, 9 Jul 2015 22:32:29 +0000 Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> 2015-07-09 18:46, Yong Wang: > > On 7/9/15, 11:24 AM, "dev on behalf of stephen at networkplumber.org" > > <dev-bounces at dpdk.org on behalf of stephen at networkplumber.org> wrote: > > >From: Stephen Hemminger <shemming at brocade.com> > > > > > >These are update to earlier vmxnet3 driver changes. Mostly rebasing > > >to current layout. I skipped the jumbo MTU stuff which works for me > > >but reviewers seem to see problems with. > > It should be possible to discuss with Yong to understand the problem > and submit a separate patch to get it approved. > > > >Stephen Hemminger (8): > > > vmxnet3: enable VLAN filtering > > > vmxnet3: remove mtu check > > > vmxnet3: cleanup txq stats > > > vmxnet3: add support for multi-segment transmit > > > vmxnet3: fix link state handling > > > vmxnet3: support RSS and refactor offload > > > vmxnet3: get rid of DEBUG ifdefs > > > vmxnet3: remove unnecessary inlining > > > > Assuming this series is a simple rebase of the previous patchset, which I > > already acked (I didn?t see the Acked-by updated though in the new > > version): > > Yes this series was partially ack'ed and some of them were forgotten in v3. > > Stephen, reviewing is not so pleasant and it can be worst when some reviews > seem forgotten. Please try to add acks and maintain a changelog across > different versions of a patchset. > > > Series Acked-by: Yong Wang <yongwang at vmware.com> > > Applied, thanks for giving quick ack I work in a Getting-Things-Done fashion and am used to 2 day turn around review time, these cycles are so long that by the time things come back all context is lost.