Hi Dharmik,
On 02/11/2020 16:58, Dharmik Thakkar wrote:
On Nov 2, 2020, at 9:11 AM, Bruce Richardson <bruce.richard...@intel.com> wrote:
On Thu, Oct 29, 2020 at 10:36:31AM -0500, Dharmik Thakkar wrote:
Fix incorrect calculations for LPM adds, LPM deletes,
and average cycles in RCU QSBR perf tests
To help review this patch, could you provide some more details in the
commit log as to what exactly was wrong with the calculation and how this
patch fixes things?
I will update the commit message in the next version. Adding it here as well:
Since, rcu qsbr tests run for ‘RCU_ITERATIONS’ and not ‘ITERATIONS’,
replace ‘ITERATIONS’ with ‘RCU_ITERATIONS’ for calculating adds, deletes, and
cycles.
Also, for multi-writer perf test, each writer only writes half of
NUM_LDEPTH_ROUTE_ENTRIES.
For 2 writers, total adds (or deletes) should be (RCU_ITERATIONS *
NUM_LDEPTH_ROUTE_ENTRIES) instead of
(2 * RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES).
Since, for both the single and multi writer tests, total adds/deletes is equal
to (RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES),
this has been replaced with a macro ’TOTAL_WRITES’ and furthermore, ‘g_writes’
has been removed since it is always a fixed value
equal to TOTAL_WRITES.
Thanks for the clarification. I left a few comments regarding 4-th
patch. First 3 patches LGTM, just put more details in the commit message.
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagaraha...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Dharmik Thakkar <dharmik.thak...@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com>
--
Regards,
Vladimir
