02/11/2020 16:47, David Marchand: > On Mon, Nov 2, 2020 at 4:41 PM Olivier Matz <olivier.m...@6wind.com> wrote: > > > --- a/lib/librte_mbuf/rte_mbuf_core.h > > > +++ b/lib/librte_mbuf/rte_mbuf_core.h > > > @@ -149,11 +149,6 @@ extern "C" { > > > */ > > > #define PKT_RX_LRO (1ULL << 16) > > > > > > -/** > > > - * Indicate that the timestamp field in the mbuf is valid. > > > - */ > > > -#define PKT_RX_TIMESTAMP (1ULL << 17) > > > - > > > /** > > > * Indicate that security offload processing was applied on the RX > > > packet. > > > */ > > > > nit: can we keep a comment here to highlight the flag 17 is unused? > > What about marking it free in free_flags?
Overkill for a single bit. We will probably use it in future. I will add a comment as suggested by Olivier.