2015-07-09 14:15, Stephen Hemminger: > On Thu, 09 Jul 2015 22:41:23 +0200 > Thomas Monjalon <thomas.monjalon at 6wind.com> wrote: > > > REJECTED > > > > 2015-07-09 11:15, Stephen Hemminger: > > > Changes in this version: > > > - rebase for PCI uio changes > > > - fix version map for 2.1 > > > - add BCM57840 support > > > > You ignore the comments which are done. > > Examples for this series: > > http://dpdk.org/ml/archives/dev/2015-June/019556.html > > http://dpdk.org/ml/archives/dev/2015-July/020714.html > > You rarely reply to comments and you seem laughing when versioning the > > patches: > > Sorry, it was so long between versions I lost track. > > > > v4 on 05-08: http://dpdk.org/ml/archives/dev/2015-May/017438.html > > v5 on 06-17: http://dpdk.org/ml/archives/dev/2015-June/019490.html > > v3 on 07-08: http://dpdk.org/ml/archives/dev/2015-July/021046.html > > v4 on 08-08: http://dpdk.org/ml/archives/dev/2015-July/021277.html > > > > This series still has some obvious errors. > > I may help to review them if you show that you care about previous comments > > like doxygen errors, correct linker file syntax or even git send-email > > guidelines. > > I will go back and fix doxygen, what is the linker issue?
The example I've given shows a keyword "global:" that you missed. > The send-email guidelines issues are unclear?? It's explained in http://dpdk.org/dev#send. Good usage of --subject-prefix, --annotate and --in-reply-to are expected. > QLogic is helping out, there maybe a couple of other changes as well.
